Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger error on 2.7.2 #463

Closed
morgoth opened this issue Nov 30, 2021 · 2 comments · Fixed by #464
Closed

Logger error on 2.7.2 #463

morgoth opened this issue Nov 30, 2021 · 2 comments · Fixed by #464
Labels
bug Something isn't working

Comments

@morgoth
Copy link
Collaborator

morgoth commented Nov 30, 2021

I'm getting an error after gem upgrade and during assets precompilation:

#> rails assets:precompile
rails aborted!
NoMethodError: undefined method `logger' for {:execution_mode=>:external, :poll_interval=>1, :shutdown_timeout=>25}:Hash
/home/wojtek/Projects/tiramizoo/trmz/config/environment.rb:5:in `<main>'

I setup GJ via initializer:

require "active_job_error_handler"

GoodJob.preserve_job_records = :on_unhandled_error
GoodJob.retry_on_unhandled_error = false
GoodJob.active_record_parent_class = "ApplicationRecord"

ActionMailer::MailDeliveryJob.include(ActiveJobErrorHandler)

and environments/develoment.rb:

  config.active_job.queue_adapter = :good_job
  config.good_job = {execution_mode: :external, poll_interval: 1, shutdown_timeout: 25}

There is also in my application.rb: require "good_job/engine"

It is working fine on 2.7.1

@morgoth morgoth added the bug Something isn't working label Nov 30, 2021
@bensheldon
Copy link
Owner

@morgoth aha! I can fix that momentarily. Caused by this: #460

@bensheldon
Copy link
Owner

Fix released in GoodJob v2.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants