uninitialized constant DiscreteExecution

[adzap]

Originating from method discrete_support? (app/models/good_job/base_execution.rb:38)` in v3.15.9

[bensheldon]

@adzap thanks for reporting this. I'm not sure why the constant lookup isn't working here, but I'll namespace it in GoodJob:: just to be sure:

good_job/app/models/good_job/base_execution.rb

Line 38 in 1c4fc07

if connection.table_exists?(DiscreteExecution.table_name)

[bensheldon]

I just released: https://github.com/bensheldon/good_job/releases/tag/v3.15.10

[adzap]

Excellent, thanks.

I was going to say it might have something to do with zeitwerk but I see you removed it. I did have other const loading issues when I was first using the gem which I resolved myself with an explicit require.

[adzap]

Has there been a regression?

Here is the fix https://github.com/bensheldon/good_job/pull/963/files?

But here is the latest code

good_job/app/models/good_job/base_execution.rb

Line 38 in 1ce9aef

DiscreteExecution.migrated?

[bensheldon]

@adzap oops, sorry, that's my bad on the regression. That happened in #979 and it totally slipped my mind that the namespace was intentional.

I'll put it back and also put a custom Rubocop cop so it hopefully doesn't happen again.

[bensheldon]

I did have other const loading issues when I was first using the gem which I resolved myself with an explicit require.

Re-reading through this, I imagine something is wrong in your application because it shouldn't be necessary to do any explicit requires with Rails and Rails's Zeitwerk loader.

Can you try running bin/rails zeitwerk:check?

[adzap]

Thanks!

…

On 17 Jun 2023 at 12:23 AM +1000, bensheldon ***@***.***>, wrote: > I did have other const loading issues when I was first using the gem which I resolved myself with an explicit require. Re-reading through this, I imagine something is wrong in your application because it shouldn't be necessary to do any explicit requires with Rails and Rails's Zeitwerk loader. Can you try running bin/rails zeitwerk:check? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[adzap]

I don’t use the zeitwerk loader.

…

On 17 Jun 2023 at 12:23 AM +1000, bensheldon ***@***.***>, wrote: > I did have other const loading issues when I was first using the gem which I resolved myself with an explicit require. Re-reading through this, I imagine something is wrong in your application because it shouldn't be necessary to do any explicit requires with Rails and Rails's Zeitwerk loader. Can you try running bin/rails zeitwerk:check? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>