Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Java resource loading with something else. #5

Open
SamJoan opened this issue Feb 18, 2020 · 0 comments
Open

Replace Java resource loading with something else. #5

SamJoan opened this issue Feb 18, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@SamJoan
Copy link
Member

SamJoan commented Feb 18, 2020

While testing the application, I noticed that Java resource loading failed under circumstance. This leads to issues where the plugins may try to load a file containing for example, a list of words and therefore silently running with an empty wordlist. The end result is that the plugin fails silently under certain conditions which is not ideal.

I think this triggers when the jar file for an extension changes without restarting burp. The workaround for now is to restart Burp whenever we recompile our jar plugins.

Here's an example call that fails:

src/burp/Utilities.java:249:        Scanner s = new Scanner(getClass().getResourceAsStream("/functions"));
src/burp/Utilities.java:256:        Scanner params = new Scanner(getClass().getResourceAsStream("/params"));

A better solution would be to modify the Java source code to fetch these resources from the hard-drive to a location within our Python repository, or putting in an assertion that crashes the plugin whenever this happens. This is slightly annoying when developing so I haven't put it in place yet.

@SamJoan SamJoan added the bug Something isn't working label Feb 18, 2020
@SamJoan SamJoan added enhancement New feature or request and removed bug Something isn't working labels Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant