Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve_gunicorn is now called with the bento param and not bundle_path #499

Closed
pdoyle5000 opened this issue Jan 24, 2020 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@pdoyle5000
Copy link

Describe the bug
bundle_path is still passed to serve_gunicorn as a kwarg and now breaks as it is an unexpected parameter. the bundle_path param needs to be switched the new new bento param as changed in the commit: abfd77c

to avoid an unexpected parameter exception. I am not confident in where along the dependency chain to make that alteration as to not affect the other severing/cli modes.

@kevlar1818 @seantur

@pdoyle5000 pdoyle5000 added the bug Something isn't working label Jan 24, 2020
@parano parano self-assigned this Jan 24, 2020
@parano
Copy link
Member

parano commented Jan 24, 2020

@pdoyle5000 thanks for reporting the bug!

Passing bundle_path to server/gunicorn_serve should still work, we made it backward compatible by design. This error was due to the naming of the parameter was wrong, a bug introduced in abfd77c
We are working on a fix now.

@parano
Copy link
Member

parano commented Jan 24, 2020

@pdoyle5000 Submitted a PR fixing the issue here #500

Since this bug breaks the docker API server run, we will follow up with a minor release 0.6.1 to include this bug fix. Thanks again for reporting the issue.

@parano
Copy link
Member

parano commented Jan 24, 2020

Release 0.6.1 is out now including the fix in #500 @pdoyle5000

@parano parano closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants