Skip to content

Rllib test #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rllib test #66

wants to merge 4 commits into from

Conversation

@berkeleyflow
Copy link
Owner

  • added a test for the figure eight of benchmarks being run in rllib. This also helps us test that parallelism isn't broken somehow.

AboudyKreidieh
AboudyKreidieh reviewed Aug 17, 2018
View reviewed changes
tests/fast_tests/test_rllib_examples.py Outdated
config["clip_param"] = 0.2
config["sgd_batchsize"] = horizon

# save the flow params for replay
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take this out from test. it won't fix it, but if this fails we'll be getting two tests failing instead of one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AboudyKreidieh AboudyKreidieh AboudyKreidieh left review comments

@cathywu cathywu Awaiting requested review from cathywu cathywu is a code owner

@eugenevinitsky eugenevinitsky Awaiting requested review from eugenevinitsky eugenevinitsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@berkeleyflow @AboudyKreidieh @eugenevinitsky