[Bug?] bandwidth_threshold in config is supposedly megabits but compared to kilobits from hostapd

[MGunlogson]

Hello again!

I think DAWN is comparing megabits in configuration for bandwidth_threshold against kilobits reported by hostapd. I'm getting log messages about not kicking because bandwidth use is 1500 (impossible on my gigabit lan) when limit is at default 6 . DAWN code assumes hostapd is returning megabits, when it seems to be returning kilobits.

The relevant code is here

DAWN/src/storage/datastorage.c

Line 569 in e036905

dawnlog_info("Client " MACSTR ": Don't kick due to active data transfer: RX rate %f exceeds %d limit\n", MAC2STR(j->client_addr.u8), rx_rate, dawn_metric.bandwidth_threshold);

I'm not sure if hostapd reports client bandwidth differently depending on the wireless driver? I'm running the newest stable OpenWrt (22.03.5) on some E8450's which have MediaTek drivers. With package hostapd-openssl.