Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way/plugin to add mp4 support to Puppeteer.? #200

Closed
thegeekybaniya opened this issue May 15, 2020 · 4 comments
Closed

Is there a way/plugin to add mp4 support to Puppeteer.? #200

thegeekybaniya opened this issue May 15, 2020 · 4 comments

Comments

@thegeekybaniya
Copy link

thegeekybaniya commented May 15, 2020

Can we make a plugin for puppeteer to add mp4 support? We have already added a lot using this library, what would be the pathway for that, I am willing to take that up.

@danielgwilson
Copy link

You can get it working pretty easily by setting the executablePath LaunchOption to the path to your Chrome installation. Chromium does not support .mp4, but Chrome does—both work with puppeteer.

See:
puppeteer/puppeteer#291

I think is is because the MP4 codec is under a paid license fee. Which means it isn't distributed with Chromium but only within Google Chrome.

mp4 is missing in chromium: https://www.chromium.org/audio-video

@thegeekybaniya
Copy link
Author

@danielgwilson But will the puppeteer extra stealth plugin will be as effective as it is now?

@danielgwilson
Copy link

@thegeekybaniya not 100% sure but it seems to work fairly well—if others are aware of any "gotchas" that I've missed, I'd be super interested.

@berstend
Copy link
Owner

@danielgwilson But will the puppeteer extra stealth plugin will be as effective as it is now?

The stealth plugin works with all chromium based browsers :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants