Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Type attribute with importing a JS #342

Open
azdurov opened this issue Aug 2, 2024 · 1 comment
Open

Duplicate Type attribute with importing a JS #342

azdurov opened this issue Aug 2, 2024 · 1 comment

Comments

@azdurov
Copy link

azdurov commented Aug 2, 2024

Recently, changes were made to a line of code:

outPw << '<script type="' << (attrs.type ? attrs.type : 'text/javascript') << '" src="' << assetPath(src: src, useManifest: useManifest) << queryString << '" ' << paramsToHtmlAttr(outputAttrs) << '></script>' << endOfLine

This allowed to import a JavaScript with the Module type:
<asset:javascript type="module" src="application.js"/>

As a result, there is a duplication of attribute 'type' in the HTML:
<script type="module" src="/assets/application.js?compile=false" type="module"></script>

@azdurov
Copy link
Author

azdurov commented Aug 29, 2024

Commit with changes: 8088a4d
Connected issue: #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant