Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inline React-CSS color styles to (s)css module file #256

Closed
ekelen opened this issue May 18, 2020 · 1 comment
Closed

Move inline React-CSS color styles to (s)css module file #256

ekelen opened this issue May 18, 2020 · 1 comment
Assignees
Labels

Comments

@ekelen
Copy link
Collaborator

ekelen commented May 18, 2020

Get rid of all the style={{ color: theme.text.sectionText }} (for example) in our components. They are used almost everywhere and can replaced with a reference to one Sass module file.

The idea would be to import a global .module.scss file; declare const { name } = useContext(themeContext), then replace style={{...}} with className={...classNames, {...styles.light}} (pseudo-code) to element attributes.

Caveat, not worth it if it doesn't visibly reduce component complexity.

@ekelen ekelen added the front label May 18, 2020
@ekelen ekelen self-assigned this May 18, 2020
@moul moul mentioned this issue Oct 1, 2020
84 tasks
@moul
Copy link
Member

moul commented Oct 1, 2020

moved to #2

@moul moul closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants