We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, we are currently having problems with specifying replacement files. They are ignored, e.g. always the defaults are used.
I followed the description here: https://docs.oracle.com/en/java/javase/14/jpackage/override-jpackage-resources.html#GUID-1B718F8B-B68D-4D46-B1DB-003D7729AAB6 and we created a custom background.tiff file in the resources folder, but it's not copied over. The default is used in the final installer. We tried naming it both background.tiff and background-jabref.tiff Similar with specifying an Info.plist
And somehow the --verbose switch is also ignored.
Do we need to pass the options somehow in another way? https://github.com/JabRef/jabref/blob/master/build.gradle#L680
if (OperatingSystem.current().isMacOsX()) { imageOptions = [ '--icon', "${projectDir}/src/main/resources/icons/jabref.icns", '--resource-dir', "${projectDir}/buildres/mac" ] installerOptions = [ '--verbose', '--vendor', 'JabRef', '--app-version', "${project.version}", '--file-associations', "${projectDir}/buildres/mac/bibtexAssociations.properties", '--resource-dir', "${projectDir}/buildres/mac" ] }
The text was updated successfully, but these errors were encountered:
@Siedlerchr To see the jpackage verbose output you also need to add the Gradle -i flag to this line:
run: ./gradlew -i -PprojVersion="${{ steps.gitversion.outputs.AssemblySemVer }} ..."
After that, you will see the following message:
Using default package resource background_dmg.tiff [dmg background] (add JabRef-background.tiff to the resource-dir to customize).
So, jpackage expects to find a file named JabRef-background.tiff in the resource-dir.
JabRef-background.tiff
Renaming your JabRef-background_dmg.tiff to JabRef-background.tiff should solve this issue:
JabRef-background_dmg.tiff
Using custom package resource [dmg background] (loaded from JabRef-background.tiff).
Sorry, something went wrong.
@siordache Thanks for the quick feedback. That works now. I will test now with the plist files as well and report back.
Just for reference, got it to work: Info.plist and Info.list.template seemed to be necessary https://github.com/JabRef/jabref/tree/master/buildres/mac
No branches or pull requests
Hi,
we are currently having problems with specifying replacement files. They are ignored, e.g. always the defaults are used.
I followed the description here: https://docs.oracle.com/en/java/javase/14/jpackage/override-jpackage-resources.html#GUID-1B718F8B-B68D-4D46-B1DB-003D7729AAB6
and we created a custom background.tiff file in the resources folder, but it's not copied over. The default is used in the final installer. We tried naming it both background.tiff and background-jabref.tiff
Similar with specifying an Info.plist
And somehow the --verbose switch is also ignored.
Do we need to pass the options somehow in another way?
https://github.com/JabRef/jabref/blob/master/build.gradle#L680
The text was updated successfully, but these errors were encountered: