Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPS rescue settings when GPS rescue is not selected as stage2 failsafe #3458

Closed
catphish opened this issue May 21, 2023 · 5 comments · Fixed by #3611
Closed

Enable GPS rescue settings when GPS rescue is not selected as stage2 failsafe #3458

catphish opened this issue May 21, 2023 · 5 comments · Fixed by #3611

Comments

@catphish
Copy link

catphish commented May 21, 2023

Is your feature request related to a problem? Please describe

I wanted to configure GPS rescue on a switch, but not enable it as my stage2 failsafe. After looking at the code and testing it, I found that this is a valid and supported configuration. However, the configurator will not allow GPS rescue settings to be changed unless GPS rescue is selected as the stage2 failsafe.

It is inconvenient and confusing to have to enable GPS stage2 failsafe in order to change these settings.

In my opinion, GPS rescue is a separate feature from failsafe, and should not be conflated in the way it is at present.

Describe the solution you'd like

I would suggest that the selection of a stage2 failsafe be decoupled from the GPS rescue settings, thus allowing GPS rescue to be configured even if it is not selected as the stage2 failsafe behaviour.

Describe alternatives you've considered

These options could be moved to a new location, and only enabled if either stage2 failsafe GPS rescue, or mode based GPS rescue is enabled. However, I see no reason to disable them in any situation.

@sugaarK
Copy link
Member

sugaarK commented May 24, 2023

You can change the settings in the cli any time you like

@haslinghuis
Copy link
Member

haslinghuis commented May 24, 2023

It is inconvenient and confusing to have to enable GPS stage2 failsafe in order to change these settings.

In my opinion, GPS rescue is a separate feature from failsafe, and should not be conflated in the way it is at present.

# get failsafe_procedure
failsafe_procedure = DROP
Allowed values: AUTO-LAND, DROP, GPS-RESCUE

@catphish
Copy link
Author

You can change the settings in the cli any time you like

You can indeed, but it's nicer to use a GUI 🙂

@catphish
Copy link
Author

catphish commented May 25, 2023

It is inconvenient and confusing to have to enable GPS stage2 failsafe in order to change these settings.

In my opinion, GPS rescue is a separate feature from failsafe, and should not be conflated in the way it is at present.

# get failsafe_procedure
failsafe_procedure = DROP
Allowed values: AUTO-LAND, DROP, GPS-RESCUE

This demonstrates that failsafe can indeed activate GPS rescue, But it's not the only way to activate GPS rescue.

The point of this issue is that GPS rescue can still be used when failsafe_procedure = DROP (using a transmitter switch), but in that case it can't be configured by the configurator.

@haslinghuis
Copy link
Member

😛 Hence the added

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants