Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomplete board information prevents further work #411

Closed
TheIsotopes opened this issue Dec 17, 2021 · 1 comment · Fixed by #412
Closed

incomplete board information prevents further work #411

TheIsotopes opened this issue Dec 17, 2021 · 1 comment · Fixed by #412

Comments

@TheIsotopes
Copy link

@klutvott123 During a test on a MatekH743 i noticed that the first run of the scripts after downloading the boardinfo fails.
After looking at the generated file, i noticed that an entry in the manufacturer_id is empty and that it breaks the first run of the scripts.
After entering manufacturer_id MTKS in the cli and restarting the script everything runs without problems.

imo should break this on all other legacy target as well.
pls can you check this ?!

@klutvott123
Copy link
Member

Fixed in #412. Test version included in PR.
This should have been able to handle empty strings, but wasn't because I forgot to wrap them in "" when writing to file.
Thanks for testing and reporting this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants