Fix SKIP_PR option for runs with installation token #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation for signed commits in #153 did not consider the `SKIP_PR` flag - if used together with an installation token it fails now. This change adds support by: 1) comparing changes against the remote branch, as base branch and HEAD are the same 2) Skipping pr branch creation 3) using the base instead of the undefined prBranch as upload target
|
🎉 This PR is included in version 1.17.20 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thanks @Nef10! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation for signed commits in #153 did not
consider the
SKIP_PRflag - if used together with an installationtoken it fails now.
This change adds support by:
are the same
Fixes #207