Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to ESM #288

Merged
merged 9 commits into from
Jan 7, 2023
Merged

chore: move to ESM #288

merged 9 commits into from
Jan 7, 2023

Conversation

balazsorban44
Copy link
Contributor

@balazsorban44 balazsorban44 commented Jan 7, 2023

GitHub Actions require a Node.js version that has ESM support, so it's unnecessary to transpile to CJS anymore.

Copy link
Owner

@BetaHuhn BetaHuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BetaHuhn BetaHuhn merged commit 6f1bf85 into BetaHuhn:master Jan 7, 2023
@balazsorban44 balazsorban44 deleted the esm branch January 7, 2023 14:15
@BetaHuhnBot
Copy link
Collaborator

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@exAspArk
Copy link
Contributor

exAspArk commented Jan 9, 2023

Hey - I'm getting this error:

> Run BetaHuhn/repo-file-sync-action@v1
  
undefined:1
require
^

ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and '/home/runner/work/_actions/BetaHuhn/repo-file-sync-action/v1/dist/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at eval (eval at 539 (file:///home/runner/work/_actions/BetaHuhn/repo-file-sync-action/v1/dist/index.js:1:41342), <anonymous>:1:1)
    at Object.539 (file:///home/runner/work/_actions/BetaHuhn/repo-file-sync-action/v1/dist/index.js:1:41342)
    at __nccwpck_require__ (file:///home/runner/work/_actions/BetaHuhn/repo-file-sync-action/v1/dist/index.js:1:42[49](https://github.com/angellist/venture/actions/runs/3868896295/jobs/6595602746#step:4:50)1)
    at file:///home/runner/work/_actions/BetaHuhn/repo-file-sync-action/v1/dist/index.js:1:42877
    at file:///home/runner/work/_actions/BetaHuhn/repo-file-sync-action/v1/dist/index.js:1:47000
    at ModuleJob.run (node:internal/modules/esm/module_job:185:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:281:24)
    at async loadESM (node:internal/process/esm_loader:88:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)
##[debug]Node Action run completed with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants