🐛 Make messages compatible with Conventional Commits #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @phnx47! If you fix the conflicts I'll be happy to merge it! |
|
@BetaHuhn I rebased my commit and force pushed, regenerated |
|
🎉 This PR is included in version 1.20.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed #176 and #87
Current messages is not compatible Conventional Commits. Look at Subject Case in Conventional Commits
I see 3 types of messages:
${ COMMIT_PREFIX } Synced file(s) with ${ GITHUB_REPOSITORY }${ COMMIT_PREFIX } Synced local '${ file.dest }' with remote '${ file.source }${ COMMIT_PREFIX } Created local '${ file.dest }' from remote '${ file.source }'It can be difficult create 1 template for 3 type of messages...
So we can start with just lower case:
Synced->synced,Created->createdI didn't test it yet because a new bug #289, I will test it later...