Invalid exception is thrown when server is unavailable

[miroljub1995]

Describe the bug
If server is currently unavailable (503 status), we receive some weird exception <' is an invalid start of a value. LineNumber: 0 | BytePositionInLine: 0.
Looks like it is missing response.EnsureSuccessStatusCode() before this line:

openai/OpenAI.SDK/Extensions/HttpclientExtensions.cs

Line 16 in 0513b27

return await response.Content.ReadFromJsonAsync<TResponse>(cancellationToken: cancellationToken) ?? throw new InvalidOperationException();

Result
Error: <' is an invalid start of a value. LineNumber: 0 | BytePositionInLine: 0.

Expected behavior
Let dotnet throw HttpRequestException so we can implement retry logic.

Desktop:

• OS: Ubuntu
• Language: c#
• Dotnet version: 7
• Lib version: 6.8.4

[winzig]

Wonder if you're seeing the same basic issue as I am: #266

[miroljub1995]

Yeah, it can be if status is not 2xx.

[Artein]

I started to receive such exceptions too. Initially thought it is something with my requests, cause I am expecting a response in JSON format. But eventually found this thread. As a workaround, I can catch that exception and retry my request.

Edit: Just realized it is planned for 7.1.0. Waiting for this release

[kayhantolga]

Using response.EnsureSuccessStatusCode() is causing additional trouble. I am planning to implement specific logic for handling 503 cases. Does anyone know how to get a 503 response from the server or has anyone saved the incoming HTML response?

[kayhantolga]

Moved to #447