Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

severity 0 has more than no effect #8

Closed
ojwenzel opened this issue Oct 28, 2019 · 1 comment · Fixed by #10
Closed

severity 0 has more than no effect #8

ojwenzel opened this issue Oct 28, 2019 · 1 comment · Fixed by #10
Labels
bug Something isn't working

Comments

@ojwenzel
Copy link

When applying image corruption with severity 0 (calling corruption()) (for example in an iterative loop), the resulting image is actually corrupted quite strongly. Maybe, either do not allow zero (as its call might be questionable), map zero to zero effect or document the meaning of zero severity.

@bmitzkus bmitzkus added the bug Something isn't working label Oct 29, 2019
@bmitzkus
Copy link
Member

Thank you for pointing out. This is due to python's array indexing magic, setting severity to 0 will actually result in corruptions of severity 5. I will add a check to make sure that only valid values can be passed to the function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants