Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with angular 1.6.1 #50

Closed
BenevidesLecontes opened this issue Jan 2, 2017 · 5 comments
Closed

Bug with angular 1.6.1 #50

BenevidesLecontes opened this issue Jan 2, 2017 · 5 comments

Comments

@BenevidesLecontes
Copy link

After upgrading from angular 1.5.10 to angular 1.6.1, i noticed this error:
TypeError: Cannot set property '$dirty' of null, because this line

// Calling overloaded method.
originalSetPristine.apply(this, arguments);

So, i changed the line above to this and everything is working fine

if (this) {originalSetPristine.apply(this, arguments);}
@trimox
Copy link

trimox commented Jan 4, 2017

Thanks!

@brunowego
Copy link

@BenevidesLecontes please make a pull request 👍

@BenevidesLecontes
Copy link
Author

@brunowego i'll do soon i can.

@slavafomin
Copy link
Member

Hello! Thank you everyone for noticing this issue. I'm sorry I wasn't been able to fix it sooner.

It's fixed now in patch level immediate releasev2.3.4. Feel free to try it out and let me know if it needs further attention.

Cheers!

@slavafomin
Copy link
Member

Also, be advised, that solution provided by @BenevidesLecontes is incorrect and probably breaks some functionality. I would recommend to update as soon as possible if you were using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants