Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container child nodes aren't returned to the original placements after drake.cancel #550

Open
guiprav opened this issue Feb 15, 2018 · 0 comments · May be fixed by #551
Open

Container child nodes aren't returned to the original placements after drake.cancel #550

guiprav opened this issue Feb 15, 2018 · 0 comments · May be fixed by #551
Labels
bug

Comments

@guiprav
Copy link

guiprav commented Feb 15, 2018

If a container has non-element child nodes (e.g. comment nodes), sometimes they arenn't returned to the same order after calling drake.cancel().

This CodePen shows hopefully demonstrates the issue very clearly on Dragula 3.7.2: https://codepen.io/anon/pen/ZrXJwd/

The fix seems to be pretty simple. I think I'll creating a PR right away. Please let me know if you recognize this as an issue that needs to be addressed. Comment nodes are used by some SPA frameworks (such as Angular and Aurelia, maybe others) and their placement is relevant to the proper functioning of the SPA, so I think this needs to be addressed (see #302).
@guiprav guiprav changed the title Container child nodes aren't returned to the same order after drake.cancel Container child nodes aren't returned to the same placements after drake.cancel Feb 15, 2018
@guiprav guiprav linked a pull request Feb 15, 2018 that will close this issue
Open
@guiprav guiprav changed the title Container child nodes aren't returned to the same placements after drake.cancel Container child nodes aren't returned to the original placements after drake.cancel Feb 15, 2018
@dcantatore dcantatore added the bug label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect non-element node original positions when reverting on cancel
2 participants
@guiprav @dcantatore