Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify github username from urls like http://shinnn.github.io #40

Closed
balupton opened this issue May 30, 2020 · 1 comment
Closed

identify github username from urls like http://shinnn.github.io #40

balupton opened this issue May 30, 2020 · 1 comment

Comments

@balupton
Copy link
Member

balupton commented May 30, 2020

places where duplicate contributors have popped up:

updating fellow, which is used by projectz to dedupe fetched contributors, to support githubUsername.github.io url patterns would solve this source of duplication

the necessary change would be here — the regexp would be updated to support both the username.github.io format and the github.com/username format, and adding support for gist.github.com/username would be great too — with a test needing to be created for it as well:

fellow/source/index.ts

Lines 313 to 318 in 9d1bca6

// github
const githubMatch = /^.+github.com\/([^/]+)\/?$/.exec(input)
if (githubMatch) {
this.githubUsername = githubMatch[1]
url = this.githubUrl = 'https://github.com/' + this.githubUsername
} else {

@balupton
Copy link
Member Author

Implemented with v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant