Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest that users use cargo add command to add Bevy #356

Closed
alice-i-cecile opened this issue Apr 19, 2022 · 4 comments
Closed

Suggest that users use cargo add command to add Bevy #356

alice-i-cecile opened this issue Apr 19, 2022 · 4 comments

Comments

@alice-i-cecile
Copy link
Member

Merged PR for the feature.

This spares users from having to reason about the Cargo.toml directly, and makes sure they're always using the latest release.

We should probably wait a bit to make sure that this lands.

@epage
Copy link

epage commented Apr 19, 2022

Yes, it'll be a couple of Rust release before this hits stable. As precedence for changing the book, we hope to update crates.io as well to provide cargo add snippets.

Just wanted to call out that more than

$ cargo add bevy

(like on quick start)

You can also do

$ cargo add bevy -F dynamic

(like on setup)

@IceSentry
Copy link
Contributor

This isn't blocked anymore, but there was some pushback on discord based on some people not liking the higher risk of typo squatting related to using cargo add. I don't necessarily agree, but it's worth considering before merging anything.

@alice-i-cecile
Copy link
Member Author

I agree; I don't think that's a particularly important concern here. Users will be running this on their home machine, and I trust the cargo team's judgement on the relative security costs.

@epage
Copy link

epage commented Jul 18, 2022

I have not heard of any concerns before for typo squatting (nor can I think of it being any different than editing Cargo.toml).

Could you point people with those concerns to our typo squatting issues so we can keep their concerns in mind when prioritizing them?

We can then also keep it in mind with my request to put cargo-add snippets on crates.io: rust-lang/crates.io#4980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants