Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast compile instruction obsolete #836

Closed
Ownezx opened this issue Dec 5, 2023 · 3 comments
Closed

Fast compile instruction obsolete #836

Ownezx opened this issue Dec 5, 2023 · 3 comments
Labels
A-Book

Comments

@Ownezx
Copy link

Ownezx commented Dec 5, 2023 •
edited
Loading

From what I understand, the LLD linker is the default as of rust 1.70 (rust-lang/rust#109721). Would make what is said on https://bevyengine.org/learn/book/getting-started/setup/ obsolete?

Does does bevy recommend a previous version of rust? Should that step be done only for users that have rust <1.70?
@alice-i-cecile
Copy link
Member

We require "latest stable at the time of the last Bevy release". So yes, now obsolete!

@QuinnPainter
Copy link

The pull request you linked only sets LLD as default for one (fairly uncommon) architecture - armv4t. I don't think modern x86-64 targets have LLD as the default yet.

@alice-i-cecile alice-i-cecile removed the E-Good-First-Issue Good for newcomers label Dec 10, 2023
@BD103
Copy link
Member

BD103 commented Feb 18, 2024

Based on how rust-lang/rust#39915, rust-lang/rust#71515, and rust-lang/rust#71520 are still open, I would say LLD is not the default yet. This issue can probably be closed for now.

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Book
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@QuinnPainter @alice-i-cecile @Ownezx @BD103