Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naga_oil does not support preprocessor definitions that end in numbers #62

Closed
alice-i-cecile opened this issue Oct 23, 2023 · 2 comments
Closed

naga_oil does not support preprocessor definitions that end in numbers #62

alice-i-cecile opened this issue Oct 23, 2023 · 2 comments

Comments

@alice-i-cecile
Copy link
Member

Reported in bevyengine/bevy#10237

@IceSentry believes this is a naga_oil problem, not a naga limitation.
@robtfm
Copy link
Collaborator

robtfm commented Oct 23, 2023 •
edited
Loading

preprocessor definitions that end in numbers or _ should be fine i think. the problem is that struct members can't end in numbers or underscores - the .uv_1 in this case.

it's captured (though badly named) in #30

@alice-i-cecile
Copy link
Member Author

Great, closing as a duplicate :)

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alice-i-cecile @robtfm