Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Translate strings that don't have translations #488

Open
christiemolloy opened this issue May 10, 2021 · 1 comment
Open

Translate strings that don't have translations #488

christiemolloy opened this issue May 10, 2021 · 1 comment

Comments

@christiemolloy
Copy link
Contributor

In the file DrawerPanelContentInfo.tsx I noticed that the strings under the titles don't have translations but do include english works e.g. up to 2 MB/second each.

@ajaypratap003 @jgiardino were these purposely left untranslated or is this something we should add?

Also since we are keeping some of the changes from summit, I think we should add translations for these strings. Let me know what you think?

@christiemolloy christiemolloy added the question Further information is requested label May 10, 2021
@jgiardino
Copy link
Contributor

I think we intentionally did not translate anything for summit, based on the assumption that it would not stick around. But it probably is worth reviewing the items we added in and identifying things that are likely to stick around. One approach is to not add translations for anything until we also have proper API support, and make both updates at the same time. It's possible that having a proper API could result in some design changes as well (e.g. the expiration data might move to the table).

@christiemolloy christiemolloy added on hold and removed question Further information is requested labels May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants