Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active health check #385

Open
iyangsj opened this issue Apr 8, 2020 · 3 comments
Open

Active health check #385

iyangsj opened this issue Apr 8, 2020 · 3 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@iyangsj
Copy link
Member

iyangsj commented Apr 8, 2020

Background

  • BFE can be configured with Passive Health Check (i.e. Outlier Detection) and use responses from real requests to determine whether an backend instance is healthy.

Description
Add Active Health Check support:

  • Actively and periodically send health checking requests to backend.
  • Use responses from health checking requests to determine whether an backend instance is healthy.

Changes to configuration

type BackendCheck struct {
	...
	CheckMode *string    // health check mode (PASSIVE/ACTIVE)
}
@iyangsj iyangsj added the good first issue Good for newcomers label Apr 8, 2020
@iyangsj iyangsj added this to the Proposal milestone Apr 16, 2020
@nitishm
Copy link

nitishm commented Jun 19, 2020

@iyangsj I would love to take on this task. What would this entail?

@iyangsj
Copy link
Member Author

iyangsj commented Jun 21, 2020

@nitishm Thanks for your contribution! The issue has been updated.

@nitishm
Copy link

nitishm commented Jun 21, 2020

@iyangsj So I make the configuration change. Where does the configuration get used? I am searching for the existing passive health check code. Looking at healthcheck.go https://github.com/baidu/bfe/blob/develop/bfe_balance/backend/health_check.go but kind find the right place to plug it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants