New Check: V2 schema.Schema.ValidateFunc Deprecation

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.Schema.ValidateFunc field is deprecated in preference of the configuration-aware ValidateDiagFunc. The new functionality is not available in version 1 of the Terraform Plugin SDK so this check should only flag version 2 usage of ValidateFunc.

New Check

• S###

Flagged Provider Code

&schema.Schema{
  ValidateFunc: /* ... */,
}

Passing Provider Code

&schema.Schema{
  ValidateDiagFunc: /* ... */,
}

References

• Diagnostics Proposal hashicorp/terraform-plugin-sdk#368
• https://pkg.go.dev/github.com/hashicorp/terraform-plugin-sdk/helper/schema?tab=doc#Schema