-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit logs #56
Merged
Merged
feat: emit logs #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foundry report forge 0.2.0 (edf15ab 2023-02-22T00:04:47.848778416Z) Build loginstalling solc version "0.8.17"
Successfully installed solc 0.8.17
Compiling 59 files with 0.8.17
Solc 0.8.17 finished in 13.20s
Compiler run successful
| Contract | Size (kB) | Margin (kB) |
|--------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.272 | 24.304 |
| AaveMisc | 0.086 | 24.49 |
| AaveV2Ethereum | 0.086 | 24.49 |
| AaveV2EthereumAssets | 0.086 | 24.49 |
| AaveV3Polygon | 0.086 | 24.49 |
| AaveV3PolygonAssets | 0.086 | 24.49 |
| AaveV3PolygonMockListing | 1.976 | 22.6 |
| Address | 0.086 | 24.49 |
| BridgeExecutorHelpers | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| DataTypes | 0.086 | 24.49 |
| GenericV3ListingEngine | 10.088 | 14.488 |
| GovHelpers | 0.086 | 24.49 |
| MockExecutor | 5.755 | 18.821 |
| ProxyHelpers | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| stdError | 0.591 | 23.985 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 | Test success 🌈No files changed, compilation skipped
Running 1 test for src/test/ProtocolV2TestBase.t.sol:ProtocolV2TestBaseTest
�[32m[PASS]�[0m testSnpashot() (gas: 4095616)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 218.34ms
Running 1 test for src/test/GenericV3ListingEngineTest.t.sol:GenericV3ListingEngineTest
�[32m[PASS]�[0m testEngine() (gas: 7601530)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 231.98ms
Running 1 test for src/test/ProtocolV3TestBase.t.sol:ProtocolV3TestBaseTest
�[32m[PASS]�[0m testSnpashot() (gas: 2438119)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 44.46ms
Running 1 test for src/test/GovTest.t.sol:GovernanceExistingProposalTest
�[32m[PASS]�[0m testCreateProposal() (gas: 127362)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 44.90ms
Running 1 test for src/test/GovTest.t.sol:GovernanceTest
�[32m[PASS]�[0m testCreateProposal() (gas: 540553)
Logs:
0xf8741a9c000000000000000000000000ee56e2b3d491590b5b31738cc34d5232f378a8d500000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000014000000000000000000000000000000000000000000000000000000000000001a000000000000000000000000000000000000000000000000000000000000002800000000000000000000000000000000000000000000000000000000000000340697066730000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001000000000000000000000000158a6bc04f0828318821bae797f50b0a1299d45b0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000009657865637574652829000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000106578656375746528616464726573732900000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000001
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 1.57ms
Running 2 tests for src/test/ProxyHelpersTest.t.sol:ProxyHelpersTest
�[32m[PASS]�[0m testAdmin() (gas: 3229)
�[32m[PASS]�[0m testImplementation() (gas: 3196)
Test result: �[32mok�[0m. 2 passed; 0 failed; finished in 49.67ms |
eboadom
reviewed
Feb 22, 2023
eboadom
reviewed
Feb 22, 2023
eboadom
reviewed
Feb 22, 2023
eboadom
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.