Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zkSync specific aave-proposals guide #419

Open
brotherlymite opened this issue Aug 7, 2024 · 0 comments
Open

zkSync specific aave-proposals guide #419

brotherlymite opened this issue Aug 7, 2024 · 0 comments

Comments

@brotherlymite
Copy link
Contributor

brotherlymite commented Aug 7, 2024

General guide:

  • To install zksync foundry on your machine run: ./install-foundry-zksync on this repo.
    Please note, this will override your existing forge setup. It is possible to use zksync foundry for non-zksync stuff without much issues, by just not using the --zksync flag
  • general build command for zkSync: FOUNDRY_PROFILE=zksync forge test --zksync
  • general test command for zkSync: FOUNDRY_PROFILE=zksync forge build --zksync
  • zksync/*: should contain all the contracts specific to zksync.

Guide for aave proposals on zkSync:

  • generating proposals for zkSync can be done using the generator without any extra specific changes.
  • zkSync specific payloads, tests and payload deployment and registering scripts reside in zksync/src/* directory.
  • scripts for creating proposal and writeups (.md file), independent if it has zkSync payloads or not reside in the src/* directory and not in zksync/*.
  • before a proposal is created, make sure FOUNDRY_PROFILE=zksync forge build --zksync is run before, as the proposal creation script relies on the bytecodeHash generated by the zkSync compiler to predict the create2 address of the payload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant