{fix} properly fail builder if tests fail

Fixes #21

Author: bgotink

.github/workflows/validation-workflow.yml

@@ -101,3 +101,13 @@ jobs:
         shell: bash
         run: |
           yarn ${{matrix.cli}} test integration --configuration production
+
+      - name: "Failing tests"
+        shell: bash
+        run: |
+          set +e
+          yarn ${{matrix.cli}} test integration --configuration failing
+          if [ $? -eq 0 ]; then
+            echo "Expected command to fail"
+            exit 1
+          fi

.yarn/versions/83adbf9a.yml

@@ -0,0 +1,2 @@
+releases:
+  "@ngx-playwright/test": patch

angular.json

@@ -92,6 +92,10 @@
 						},
 						"production": {
 							"devServerTarget": ":serve:production"
+						},
+						"failing": {
+							"baseUrl": "http://localhost:65535",
+							"config": "integration/playwright-test-failure.e2e-config.js"
 						}
 					}
 				}

integration/e2e/failing-specs/functionality.e2e-spec.js

@@ -0,0 +1,5 @@
+import {test, expect} from "@ngx-playwright/test";
+
+test("fails", () => {
+	expect(true).toBe(false);
+});

integration/playwright-test-failure.e2e-config.js

@@ -0,0 +1,24 @@
+// @ts-check
+// cspell:ignore lcovonly lcov
+
+import {join, dirname} from "path";
+import {fileURLToPath} from "url";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+
+/**
+ * @type {import('../packages/test/src/index.js').PlaywrightTestConfig}
+ */
+const config = {
+	use: {
+		channel: "chrome",
+		headless: true,
+	},
+
+	testDir: join(__dirname, "e2e/failing-specs"),
+	testMatch: "**/*.e2e-spec.js",
+
+	reporter: process.env.CI ? "github" : "list",
+};
+
+export default config;

package.json

@@ -14,7 +14,7 @@
 		"@angular/cli": "^18.2.0",
 		"@nrwl/linter": "^12.8.0",
 		"@snuggery/build-node": "0.11.0",
-		"@snuggery/snuggery": "0.13.0",
+		"@snuggery/snuggery": "0.13.1",
 		"@snuggery/yarn": "0.7.1",
 		"@typescript-eslint/eslint-plugin": "^6.14.0",
 		"@typescript-eslint/parser": "^6.14.0",

packages/test/package.json

@@ -48,7 +48,7 @@
 		"@playwright/test": "^1.20.2",
 		"@snuggery/architect": "^0.11.0",
 		"@snuggery/schematics": "^0.11.0",
-		"@snuggery/snuggery": "^0.13.0",
+		"@snuggery/snuggery": "^0.13.1",
 		"composed-dom": "^1.1.0"
 	},
 	"devDependencies": {

packages/test/src/builder/builder.js

@@ -101,7 +101,7 @@ export async function execute(input, context) {
 	const {baseUrl, stop} = await getBaseUrl(input, context);
 
 	try {
-		await firstValueFrom(
+		const result = await firstValueFrom(
 			context,
 			scheduleTarget(
 				{
@@ -161,6 +161,9 @@ export async function execute(input, context) {
 				context,
 			),
 		);
+
+		// Only pass the status through, playwright will already have printed information on the failure
+		return {success: result.success};
 	} finally {
 		await stop();
 	}

yarn.lock

@@ -1975,7 +1975,7 @@ __metadata:
     "@playwright/test": "npm:^1.20.2"
     "@snuggery/architect": "npm:^0.11.0"
     "@snuggery/schematics": "npm:^0.11.0"
-    "@snuggery/snuggery": "npm:^0.13.0"
+    "@snuggery/snuggery": "npm:^0.13.1"
     "@types/node": "npm:^20.12.12"
     composed-dom: "npm:^1.1.0"
     rxjs: "npm:7.8.0"
@@ -2497,9 +2497,9 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@snuggery/snuggery@npm:0.13.0, @snuggery/snuggery@npm:^0.13.0":
-  version: 0.13.0
-  resolution: "@snuggery/snuggery@npm:0.13.0"
+"@snuggery/snuggery@npm:0.13.1, @snuggery/snuggery@npm:^0.13.1":
+  version: 0.13.1
+  resolution: "@snuggery/snuggery@npm:0.13.1"
   dependencies:
     "@angular-devkit/architect": "npm:>= 0.1800.0 < 0.1900.0"
     "@angular-devkit/core": "npm:^18.0.0"
@@ -2519,7 +2519,7 @@ __metadata:
     typanion: "npm:^3.12.1"
   bin:
     sn: bin.js
-  checksum: 6592009cf5191ceb48333d68df5fa0c5acfcfc4637ab435522ac13c60e47f10768365c7a5a0e36819118846a5e19441137c6cc4e120a7162be415d7d2a49b2c5
+  checksum: cdc5d1988613efbc2b40aa3ccc2e5f48a0b656dab42d66c385455f11831ca56b0f2ad92bdaabc7efbb661b2f7a8b852dff1301fb19e235e3878d6385db8c7eb1
   languageName: node
   linkType: hard
 
@@ -7342,7 +7342,7 @@ __metadata:
     "@angular/cli": "npm:^18.2.0"
     "@nrwl/linter": "npm:^12.8.0"
     "@snuggery/build-node": "npm:0.11.0"
-    "@snuggery/snuggery": "npm:0.13.0"
+    "@snuggery/snuggery": "npm:0.13.1"
     "@snuggery/yarn": "npm:0.7.1"
     "@typescript-eslint/eslint-plugin": "npm:^6.14.0"
     "@typescript-eslint/parser": "npm:^6.14.0"