Adds ability to plot throughput on summary page. #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased to latest master |
|
@lemmih I have tested this PR, and it solves exactly a limitation I have encountered with Criterion. I am not familiar with Criterion's code base, but the changes look reasonable to me from a quick look. Is there anything in particular blocking this PR? Can @h33p or I do something to get it merged? Of course, I understand if you do not have the time to answer this. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bheisler/cargo-criterion#9.
This was originally based on #315. I ported it to latest version, including support for the plotters backend. Both time and throughput charts are very similar, thus I decided to go additional arguments to
Plotter::line_comparisonfunction rather than a separate one.Most notably, added
LinePlotConfigtype which configures whetherline_comparisonplots time or throughput. I had to employ a slightly dirty hack in throughput'sLinePlotConfigscaling function, to make throughput scale consistent across the plot. It could have been possible to make it cleaner with modifications toValueFormatter, but I decided against breaking public API.