-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclosed httpx.AsyncClient warning #6
Comments
Hello, thank you for reporting the issue! It was about time I looked on this library again, possibly adding some new features, since bitcoin core 0.21 was released... The warning you receive was introduced here: encode/httpx#1197. I will take a closer look on it during this weekend and once again, thank you for reporting. Libor |
Hi there. Thanks for the library. I'm using the library and getting the same error @jeanmonet quote above. Please help us to check it up. |
Hey guys, sorry for the late response, I was partly busy IRL and partly slacking... :D Since I am not near the Bitcoin node I operate and therefore unable to query it, I looked around the interwebs for running It is not up to date, running Bitcoin Core v0.17.1 but it is sufficient for now - This commit 645c25d adds a simple script for running regtest locally on port 18443 with This also opens a possibility for better testing, since I can setup/teardown the regtest container in an instant - stay tuned! :) But, to your problem, I have confirmed it and had the same issue with this simple script run from CLI:
To close the Slightly modified script from above:
no longer emits the warning. However, remembering to
What do you think @feavilan04, @jeanmonet ? Anyway, I will push the new version of this package to PyPI in few days. Thank you both for your feedback and I promise my responses will be faster next time! Libor |
Thanks a lot @bibajz for the library, the last approach seems perfect for the job, let me know if you need anything. Regards. |
The first solution using explicit |
Hey @jeanmonet, indeed it was... :) I have implemented async context manager today, pushing it soon. Both options, calling the |
OK, new version - Thanks a lot! @jeanmonet @feavilan04 |
Awesome thanks! |
Hi - thank you for this great (and light) library!
Upon exiting the script, I often get the following warning:
I'm not really familiar with the httpx library so not sure what this implies. Should the bitcoinrpc library provide a call to close the httpxAsyncClient?
The text was updated successfully, but these errors were encountered: