Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno validator: warning missing events.tsv file for emptyroom noise task #2137

Open
monique2208 opened this issue Sep 20, 2024 · 1 comment

Comments

@monique2208
Copy link

I am getting a warning EVENTS_TSV_MISSING about the noise task that is part of empty room data for an meg dataset. Since this is explicitly how this task should be labelled according to the specification, should there not be an exception for noise as there is for rest?

EVENTS_TSV_MISSING Task scans should have a corresponding 'events.tsv' file.
If this is a resting state scan you can ignore this warning or rename the task to include the word "rest".
		/sub-emptyroom/ses-20190619/meg/sub-emptyroom_ses-20190619_task-noise_channels.tsv
		/sub-emptyroom/ses-20190619/meg/sub-emptyroom_ses-20190619_task-noise_meg.fif
		12 more files with the same issue

we are actually upgrading this warning to an error for our system, is there a way to avoid this error for the noise task specifically through configuration?

@effigies
Copy link
Collaborator

The place to fix this will be in the schema:

https://github.com/bids-standard/bids-specification/blob/0698f5a59db2e06c4559473c34432ce03b2306d5/src/schema/rules/checks/events.yaml#L4-L19

I would add the following selector:

    - (datatype != "meg" || entities.subject != "emptyroom")

Rather than matching on task-noise, catching the meg/sub-emptyroom seems better targeted to this case.

Would you be willing to open a PR over on the spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants