Merge pull request #523 from bifrost-finance/slp-xcm-v3

fix on_initialize counter
bifrost-io · Mar 31, 2022 · ebbc065 · ebbc065
2 parents 022bb40 + 161e0b3
commit ebbc065
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/pallets/slp/src/lib.rs b/pallets/slp/src/lib.rs
@@ -1693,7 +1693,10 @@ pub mod pallet {
 
 			// Deal with DelegatorLedgerXcmUpdateQueue storage
 			for query_id in DelegatorLedgerXcmUpdateQueue::<T>::iter_keys() {
-				ensure!(counter <= T::MaxTypeEntryPerBlock::get(), Error::<T>::GreaterThanMaximum);
+				if counter >= T::MaxTypeEntryPerBlock::get() {
+					break;
+				}
+
 				let updated = Self::get_ledger_update_agent_then_process(query_id, false)?;
 				if updated {
 					counter = counter.saturating_add(1);
@@ -1702,7 +1705,9 @@ pub mod pallet {
 
 			// Deal with ValidatorsByDelegator storage
 			for query_id in ValidatorsByDelegatorXcmUpdateQueue::<T>::iter_keys() {
-				ensure!(counter <= T::MaxTypeEntryPerBlock::get(), Error::<T>::GreaterThanMaximum);
+				if counter >= T::MaxTypeEntryPerBlock::get() {
+					break;
+				}
 				let updated =
 					Self::get_validators_by_delegator_update_agent_then_process(query_id, false)?;