Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a new nb-trans component to render complex content #22

Closed
bigBear713 opened this issue Mar 18, 2023 · 3 comments · Fixed by #24 or #40
Closed

Provide a new nb-trans component to render complex content #22

bigBear713 opened this issue Mar 18, 2023 · 3 comments · Fixed by #24 or #40
Assignees
@bigBear713
Labels
enhancement New feature or request

Comments

@bigBear713
Copy link
Owner

bigBear713 commented Mar 18, 2023 •
edited
Loading

version: v15.2.0

Now when we want to render a complex content, we can use <nb-trans></nb-trans> component. By there will always have a nb-trans tag, it is not good in some scenarios, such as setting style via html tag. So I hope the nb-trans tag can be non-existent when I need.
@bigBear713 bigBear713 self-assigned this Mar 18, 2023
@bigBear713 bigBear713 added the enhancement New feature or request label Mar 18, 2023
@bigBear713
Copy link
Owner Author

In [nb-trans] component, the input properties should be more specific, key, options are so common, so there may be conflicts with the other components/direcitves' input proterties

@bigBear713 bigBear713 linked a pull request May 3, 2023 that will close this issue
Issue/22 #24
Merged
@bigBear713
Copy link
Owner Author

I think the nb-trans-key prop is redundant.
It would be better to use nb-trans instead

@bigBear713 bigBear713 linked a pull request May 17, 2023 that will close this issue
Issue/22 #40
Merged
@bigBear713
Copy link
Owner Author

It is provided in v16.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigBear713 bigBear713

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/22 bigBear713/nb-trans
Issue/22 bigBear713/nb-trans
1 participant
@bigBear713