-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs version across all neeto products #535
Comments
@yedhink Fair point. I think we can upgrade to 16. No point in staying well behind the latest. I'm guessing there are not many breaking changes and that the upgrade will be smooth. |
@amrutsabale _a Please start by porting the node version in this repo. We will take up changing the node versions in other repos, iteratively. Once you change the node version, please ensure that the application is working. Also please take a look at the docker script within You should also run the docker script to verify it's working after version update. You can port node to Let me know if you have any queries. |
@yedhink previously, I had installed Nodejs |
@amrutsabale We should try to install 16.xx without Rosetta. |
@yedhink please go through this video. https://www.loom.com/share/a08b2c0bc0bd49c096089a80fcffd29b links of the issue I faced while installing the wheel project after the latest node version update: For Node 16, node-sass version 6.0.1, is supported. Also, let me know, can I raise PR with these changes? Thanks. |
I have one concern here. As node 16 support only node-sass version >=6. If any package internally uses a lower node-sass version then it will not work properly with node 16. I've mentioned in video that in So If we are going with node 16, these types of changes we need to make in projects which are using packages dependent on |
Thanks for the very detailed video. Much appreciated. Can you confirm that you installed node v16.4.2 like mentioned in our book? If yes, then start by raising an issue in Also please mention the command you had used to update |
Yes, I had installed node v16.4.2 with I will also raise an issue for the The command I had used to update webpacker |
@amrutsabale _a Command to upgrade |
From my understanding nodejs versions less than 16.xx are not natively supported in M1 Mac. Currently for M1 mac nodejs 14.xx can be installed via Rosetta. All nodejs 16.xx versions are natively supported in M1 chip.
Refer: nodejs/TSC#886 (comment)
The current version that we are using is 14.13.1, which doesn't show any LTS support in the official website either. But 14.17.3 is an active LTS(Fermium).
Refer: https://nodejs.org/en/download/releases/
@vinay0x
Should we upgrade all the node versions across all the neeto products as well as wheel to say either 14.17.3 or some version of 16.xx?
The text was updated successfully, but these errors were encountered: