Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactoring for new release. #463

Open
2 of 5 tasks
ypriverol opened this issue Dec 20, 2024 · 3 comments
Open
2 of 5 tasks

Major refactoring for new release. #463

ypriverol opened this issue Dec 20, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ypriverol
Copy link
Member

ypriverol commented Dec 20, 2024

Description of feature

The following error #459 triggered a discussion about the new OpenMS version and quantms. We should refactor the pipeline for the new OpenMS version.

  • CI/CD ci.yml testing in dev PRs should always use the newest version of OpenMS dev profile singularity and docker. Conda must be only tested in PRs against master
  • ProteinInference should always make sure that will be using the PEP score: -Algorithm:score_type "PEP"
  • Remove IDFilter after PercolatorAdapter, Percolator adapter will have this possibility now.
  • IDSwitcher is not needed.
  • Remove PSMFeatureExtractor All the search engines will have the features afterwards. No need to rerun this.

Feedback @timosachsenberg @jpfeuffer

@ypriverol ypriverol added the enhancement New feature or request label Dec 20, 2024
@jpfeuffer
Copy link
Collaborator

Do we really have an IDFilter after the search engines? I thought only after Percolator.
And we added filtering to the PercolatorAdapter

@ypriverol
Copy link
Member Author

Yes sorry, I edited the original post.

@ypriverol
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants