Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding full label internationalization support #1194

Closed
davelinke opened this issue Apr 17, 2023 · 2 comments
Closed

Adding full label internationalization support #1194

davelinke opened this issue Apr 17, 2023 · 2 comments

Comments

@davelinke
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Within the component library there are a few components that have got labels or attributes that are written in english and cannot be changed to other languages.

Here's a list of such components and possible solutions:

Pagination Component
Needs the word "of" to be passed as a property/attribute to be able to internationalize.

Stateful table with Search
Needs the word "Search" to be passed as a property/attribute to be able to internationalize, or needs to provide the instance of the search input as property to do it directly on the child component.

Stateful Table with pagination
The assumption is that this one gets fixed by fixing the pager component.

Stateful Table with Drag and drop
Needs a property/attribute to be added to provide an alt/title property on the dragging icon to show a proper message in any language

Table with pagination
The assumption is that this one gets fixed by fixing the pager component.

Table - Sortable
Needs the labels "Ascending Order" and "Descending Order" that are provided as "alt/title" tags for the icons to be passed as a property/attribute to be able to internationalize.

Table with Drag and Drop
Same as "stateful table" with drag and drop.

Worksheet - Expandable Rows
Needs the phrase "toggle row expanded" to be passed as a property/attribute to be able to internationalize.

ButtonGroup
Needs the word "more" that is provided as an "alt/title" tag for the ellipsis icon to be passed as a property/attribute to be able to internationalize.

Counter
Needs the labels "Decrease Count" and "Increase Count" that are provided as "alt/title" tags for the icons to be passed as a property/attribute to be able to internationalize.

Input, Select, MultiSelect, Textarea, DatePicker, TimePicker
The Form inputs need the word "Optional" to be passed as a property/attribute to be able to internationalize.

Search
Needs the word "Search" to be passed as a property/attribute to be able to internationalize.

InlineMessage
Needs the word "close" that is provided as an "alt/title" tag for the closing icon to be passed as a property/attribute to be able to internationalize.

Message
Needs the word "close" that is provided as an "alt/title" tag for the closing icon to be passed as a property/attribute to be able to internationalize.

Making it possible to pass those labels to the components would allow the library to be fully compatible with other languages other than english.

Describe the solution, feature, or improvement you'd like
My suggestion would be adding additional properties to such components to be able to pass a string in the desired language.

@jorgemoya
Copy link
Contributor

I agree that we should add these as props, however need to discuss what is the right approach for this.

Would it make sense to have a localize prop as an object for the scenario of multiple localization strings per component?

@chanceaclark
Copy link
Contributor

Fixed via v0.37.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants