Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): handle 1-liner noInline returns on CodePreview #154

Merged
merged 1 commit into from
Aug 13, 2019
Merged

fix(docs): handle 1-liner noInline returns on CodePreview #154

merged 1 commit into from
Aug 13, 2019

Conversation

deini
Copy link
Member

@deini deini commented Aug 13, 2019

Code transform wasn't working for 1-liners eg:

render <Text />;
after this change:
render(<Text />);

@deini deini requested a review from a team August 13, 2019 16:57
@deini deini merged commit e125c77 into bigcommerce:master Aug 13, 2019
@deini deini deleted the templateStrings branch August 13, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemoya jorgemoya jorgemoya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deini @jorgemoya