Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): add Table component #201

Merged
merged 9 commits into from
Sep 23, 2019
Merged

feat(component): add Table component #201

merged 9 commits into from
Sep 23, 2019

Conversation

chanceaclark
Copy link
Contributor

What

Adding basic Table component.

A few notes:

  • Documentation page is disabled for now; still a WIP.
  • Needed the checkbox to render without a label. For now, just adding boolean as a property type so we could pass in false. Need to come up with a way to have a visually hidden label.
  • Wrapped Pagination Dropdown in a Flex.Item for correct positioning.

Screenshot

Screen Shot 2019-09-23 at 10 42 01 AM

@chanceaclark chanceaclark requested a review from a team September 23, 2019 16:19
@chanceaclark chanceaclark force-pushed the feature/basic-table branch 3 times, most recently from 357807b to 776f159 Compare September 23, 2019 16:51
rtalvarez
rtalvarez approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@rtalvarez rtalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor questions below, otherwise lgtm

packages/big-design/src/components/Table/Body/Body.tsx Outdated Show resolved Hide resolved
packages/big-design/src/components/Table/Footer/Footer.tsx Outdated Show resolved Hide resolved
packages/big-design/src/components/Table/Head/Head.tsx Outdated Show resolved Hide resolved
@chanceaclark chanceaclark merged commit 64b7dcd into bigcommerce:master Sep 23, 2019
@chanceaclark chanceaclark deleted the feature/basic-table branch September 23, 2019 19:43
amckemie pushed a commit to amckemie/big-design that referenced this pull request Sep 30, 2019
@chanceaclark
feat(component): add Table component (bigcommerce#201)
43672f2
@chanceaclark chanceaclark mentioned this pull request Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemoya jorgemoya jorgemoya left review comments

@rtalvarez rtalvarez rtalvarez approved these changes

@deini deini deini approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chanceaclark @jorgemoya @deini @rtalvarez