Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component): allow 0 as values in select and fix docs #257

Merged
merged 2 commits into from
Nov 12, 2019
Merged

fix(component): allow 0 as values in select and fix docs #257

merged 2 commits into from
Nov 12, 2019

Conversation

jorgemoya
Copy link
Contributor

I want to enforce options to have a value, therefore I validate if it is set. Before it wouldn't allow 0 as a valid value.

Fixed the width of selects in docs.

@jorgemoya jorgemoya requested a review from a team November 12, 2019 16:44
@jorgemoya jorgemoya merged commit 92c6238 into bigcommerce:master Nov 12, 2019
@jorgemoya jorgemoya deleted the fix-select-falsy branch November 12, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtalvarez rtalvarez rtalvarez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgemoya @rtalvarez