fix(docs): prevent hashes on links from being overwritten #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the issue is related to #244 changes. What do you think about fixing it there so we can keep using the same component? |
jorgemoya
force-pushed
the
use-link-for-hash
branch
from
14688e6 to
8f48b36
Compare
jorgemoya
changed the title
chanceaclark
approved these changes
Nov 20, 2019
jorgemoya
force-pushed
the
use-link-for-hash
branch
from
8f48b36 to
bd2e311
Compare
jorgemoya
force-pushed
the
use-link-for-hash
branch
from
bd2e311 to
2497290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of
NextLinkswith hashes not working in live docs.I wasn't able to reproduce this issue locally while
yarn run start, but verified they don't work on production.