feat(component): convert Dropdown/Select to FC and add MultiSelect #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
So about my concerns with module size: I did a analysis by bundling the es module with webpack, these are the stats I received:
368 KiB - [Downshift]
353 KiB - [w/o]
So that's if someone bundled the entire BigDesign library with their app. I'm not concerned with those numbers. Maybe we should do some more testing around that though?
deini
reviewed
Jan 2, 2020
| openMenu(); | ||
| }, | ||
| onKeyDown: (event: any) => { | ||
| if (multi && event.key === 'Backspace' && !inputValue) { |
There was a problem hiding this comment.
Should we be checking for inputValue.length? Could there be a corner case with 0?
There was a problem hiding this comment.
Hm, I fail to see why it needs to change, tbh. inputValue is a string, and will only return falsey if it's "" right (which is what I want)?
jorgemoya
force-pushed
the
dropdown-refactor-v3
branch
4 times, most recently
from
a0cb9fe to
460248d
Compare
jorgemoya
changed the title
jorgemoya
force-pushed
the
dropdown-refactor-v3
branch
4 times, most recently
from
50cda46 to
16cadf5
Compare
jorgemoya
force-pushed
the
dropdown-refactor-v3
branch
7 times, most recently
from
e5d2b3b to
526430d
Compare
jorgemoya
force-pushed
the
dropdown-refactor-v3
branch
from
08e268a to
ac1b891
Compare
jorgemoya
force-pushed
the
dropdown-refactor-v3
branch
2 times, most recently
from
b46f91f to
6280bd9
Compare
chanceaclark
approved these changes
Feb 18, 2020
jorgemoya
force-pushed
the
dropdown-refactor-v3
branch
from
f6a8504 to
0f6e6e0
Compare
deini
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** BREAKING CHANGES**
Changes