feat(component): convert Form to FC and remove static members #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golcinho
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
PR looks good! I have a few questions not related to the code...
The question is do we support Semantic Versioning?
For zero major version API changes is good, but will we support Semantic Versioning and backwards compatibility in the scope of major version after the beta?
|
@golcinho Yes, we are and will continue to use |
deini
approved these changes
Jan 14, 2020
BREAKING CHANGE: Use `FormControlError`, `FormControlLabel`, `FormGroup`, and `Fieldset` instead of `Form.Error`, `Form.Label`, `Form.Group`, and `Form.Fieldset` respectively.
chanceaclark
force-pushed
the
refactor/form
branch
from
20c2adc to
d001c1a
Compare
deini
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Convert
Formto a functional component and remove static members.BREAKING CHANGE:
Use
FormControlError,FormControlLabel,FormGroup, andFieldsetinstead of
Form.Error,Form.Label,Form.Group, andForm.Fieldsetrespectively.