Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): adding actions to alert component #453

Merged
merged 13 commits into from
Sep 30, 2020

Conversation

golcinho
Copy link
Contributor

@golcinho golcinho commented Sep 15, 2020

What?

Adding actions prop to the InlineAlert and Message component.

  • Updated unit tests
  • Updated docs

Screenshots

Screenshot 2020-09-29 at 12 15 28

Screenshot 2020-09-29 at 12 16 42

Screenshot 2020-09-29 at 12 16 53

Screenshot 2020-09-29 at 12 17 14

Proof

Unit tests, local testing.

ping @chanceaclark

@golcinho golcinho requested a review from a team as a code owner September 15, 2020 09:11
@golcinho golcinho added the do not merge Don't merge this PR! label Sep 15, 2020
@chanceaclark
Copy link
Contributor

So everyone's is aware, we need to have a discussion with the Design team about this. We'll talk about it in the next feedback session.

@golcinho
Copy link
Contributor Author

ping @valterfatia

@golcinho golcinho removed the do not merge Don't merge this PR! label Sep 21, 2020
@golcinho golcinho added the do not merge Don't merge this PR! label Sep 22, 2020
Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@golcinho thanks for this! Here's a few changes.

packages/big-design/src/components/Message/Message.tsx Outdated Show resolved Hide resolved
packages/docs/PropTables/InlineAlertPropTable.tsx Outdated Show resolved Hide resolved
packages/docs/PropTables/MessagePropTable.tsx Outdated Show resolved Hide resolved
packages/big-design/src/utils/messagingHelpers.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments around the updates. Let me know if it doesn't make sense!

packages/big-design/src/utils/messagingHelpers.tsx Outdated Show resolved Hide resolved
packages/big-design/src/components/Message/styled.ts Outdated Show resolved Hide resolved
packages/big-design/src/components/Message/styled.ts Outdated Show resolved Hide resolved
packages/big-design/src/components/Message/Message.tsx Outdated Show resolved Hide resolved
packages/big-design/src/components/InlineAlert/styled.ts Outdated Show resolved Hide resolved
@golcinho golcinho merged commit fe8eeab into bigcommerce:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants