feat(component): use ReactNode for table actions #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE:
Table and StatefulTable `actions` prop changed from expecint a
React.ComponentType to React.ReactNode.
Old:
```jsx
<Table actions={() => <Button>Some Action</Button>} />
```
New:
```jsx
<Table actions={<Button>Some Action</Button>} />
```
deini
force-pushed
the
feat/table-actions
branch
from
6789b98 to
48d1666
Compare
chanceaclark
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue of re-rendering custom table actions.
Repro: https://codesandbox.io/s/priceless-hill-dus8q?file=/src/App.tsx (type on the input)
BREAKING CHANGE:
Table and StatefulTable
actionsprop changed from expecint aReact.ComponentType to React.ReactNode.
Old:
New: