feat(docs): update checkbox page to use new layout #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemoya
commented
Oct 7, 2021
| types: [ | ||
| 'string', | ||
| <NextLink | ||
| key="checkbox-description-prop-table" |
There was a problem hiding this comment.
Had to add a key since it's in an array.
jorgemoya
force-pushed
the
update-checkbox-page
branch
2 times, most recently
from
087927a to
8a610f1
Compare
jorgemoya
force-pushed
the
update-checkbox-page
branch
from
fb35708 to
bf2a97d
Compare
chanceaclark
approved these changes
Oct 7, 2021
Comment on lines
+14
to
+17
| <Text bold>When to use it:</Text> | ||
| <List> | ||
| <List.Item>Use checkboxes when users can make toggle one or more items in a form.</List.Item> | ||
| </List> |
There was a problem hiding this comment.
In hindsight, we probably should have make a component for this 🤔 (just a comment, no action needed)
jorgemoya
force-pushed
the
update-checkbox-page
branch
from
bf2a97d to
378c68c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update Checkbox page to use new layout.
Screenshots/Screen Recordings
Testing/Proof
N/A