feat(docs): update grid page to use new layout #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/docs/pages/grid.tsx
Outdated
| </Text> | ||
| <Panel header="Overview" headerId="overview"> | ||
| <Text> | ||
| <Code primary>Grid</Code> is a two-dimensional grid-based layout system. |
There was a problem hiding this comment.
Let's just say something similar as to what is in the Flex PR.
Suggested change
| <Code primary>Grid</Code> is a two-dimensional grid-based layout system. | |
| The <Code primary>Grid</Code> component extends the <Code primary>Box</Code> utility component and provides a <Link href="https://developer.mozilla.org/en-US/docs/Web/CSS/grid" external target="_blank" rel="external nofollow noreferrer">CSS grid</Link> container alongside grid properties. |
packages/docs/pages/grid.tsx
Outdated
| <GuidelinesTable | ||
| recommended={[ | ||
| <> | ||
| Use <Link href="https://css-tricks.com/snippets/css/complete-guide-grid/">CSS-Tricks complete guide</Link>{' '} |
There was a problem hiding this comment.
We probably want this on the Flex PR too 🤦
Suggested change
| Use <Link href="https://css-tricks.com/snippets/css/complete-guide-grid/">CSS-Tricks complete guide</Link>{' '} | |
| Use <Link href="https://css-tricks.com/snippets/css/complete-guide-grid/" external target="_blank" rel="external nofollow noreferrer">CSS-Tricks complete guide</Link>{' '} |
Comment on lines
+211
to
+229
| Don’t use <Code primary>Grid</Code> when focusing on content flow. Use{' '} | ||
| <NextLink href="flex">Flex</NextLink> instead. |
chanceaclark
approved these changes
Jan 19, 2022
jorgemoya
force-pushed
the
update-grid
branch
from
97cfd76 to
82b0e94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update grid to use new layout. I'm terrible at copy so need help to fill out info.
Screenshots/Screen Recordings