Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Update Link documentation page to use new layout #712

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

MariaJose
Copy link
Contributor

What?

Update Link documentation page to use the new layout

Screenshots/Screen Recordings

Screen Shot 2022-02-09 at 4 21 56 PM

@MariaJose MariaJose requested review from a team as code owners February 9, 2022 22:23
@eugene-polev
Copy link

Overall looks good to me. The only thing I've noticed is a typo (sentAnce) in the second option of DOs

packages/docs/pages/link.tsx Outdated Show resolved Hide resolved
packages/docs/pages/link.tsx Outdated Show resolved Hide resolved
packages/docs/pages/link.tsx Outdated Show resolved Hide resolved
@MariaJose
Copy link
Contributor Author

@chanceaclark, and @eugene-polev thanks for the feedback!
♻️

@@ -43,7 +43,7 @@ const ButtonPage = () => {
id: 'basic',
title: 'Basic',
render: () => (
<>
<Fragment key="basic">
<Text>Buttons are calls to action used throughout the product experience.</Text>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot adding the key in here 😅

@MariaJose MariaJose merged commit 4ae6247 into bigcommerce:master Feb 10, 2022
@MariaJose MariaJose deleted the link-page branch February 10, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants