feat(docs): update colors page to use new layout #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaJose
force-pushed
the
CHP-7441
branch
2 times, most recently
from
ed4889a to
c3f3bbf
Compare
MariaJose
commented
May 2, 2022
MariaJose
commented
May 2, 2022
MariaJose
commented
May 2, 2022
| { contrast: 'AAA', name: 'secondary10', textColor: 'secondary70' }, | ||
| { contrast: 'AA', name: 'secondary20', textColor: 'secondary70' }, | ||
| { contrast: 'A', name: 'secondary30', textColor: 'secondary70' }, | ||
| { contrast: 'A', name: 'secondary40', textColor: 'secondary70' }, |
There was a problem hiding this comment.
Note: I omitted color secondary70(40%) since I think we don't have this type of color in Big-design. 🤔 We just have secondary70 without the 40%.
jorgemoya
approved these changes
May 2, 2022
bc-andreadao
reviewed
May 2, 2022
bc-andreadao
approved these changes
May 2, 2022
deini
reviewed
May 3, 2022
bc-juanvasquez
pushed a commit
to bc-juanvasquez/big-design
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update colors page to use new layout.
Why?
Provide better experience to the user when reading or checking the docs.
Screenshots/Screen Recordings