Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add new layout to Spacing page #821

Merged
merged 2 commits into from
May 11, 2022

Conversation

chanceaclark
Copy link
Contributor

What?

Updates the Spacing page to use the new layout.

Why?

This should be the last page needed to update to release a new version.

Screenshots/Screen Recordings

screencapture-localhost-3000-spacing-2022-05-10-16_17_42

Testing/Proof

N/A

@chanceaclark chanceaclark marked this pull request as ready for review May 10, 2022 21:22
@chanceaclark chanceaclark requested review from a team as code owners May 10, 2022 21:22
Copy link
Contributor

@MariaJose MariaJose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍🏼 , just a minor comment

packages/docs/pages/spacing.tsx Outdated Show resolved Hide resolved
Copy link
Member

@rtalvarez rtalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the typo, otherwise lgtm

packages/docs/pages/spacing.tsx Outdated Show resolved Hide resolved
chanceaclark and others added 2 commits May 11, 2022 10:38
Co-authored-by: bc-andreadao <96258747+bc-andreadao@users.noreply.github.com>
@chanceaclark chanceaclark merged commit ea92094 into bigcommerce:master May 11, 2022
@chanceaclark chanceaclark deleted the docs/spacing branch May 11, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants